From 286e6b5c9572e8633637e9dd9dc0e5fc797a0e4a Mon Sep 17 00:00:00 2001 From: Jean-Christophe Fillion-Robin Date: Sat, 26 Nov 2016 18:25:08 -0500 Subject: [PATCH] Dockerfile: Explicitly depend on "dockcross/base:latest" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit As recommended in by CircleCI, explicitly specify the "latest" tag. This will be important when we will start versioning our images. Copied from CircleCI documentation [1]: "Make sure you tag the image you use in the FROM command in your Dockerfile, even if it is the default “latest” tag. Otherwise, Docker will pull down all tags for the image you specify. This will create significant performance problems because the save/load strategy described above only caches the image layers (and thus tags) that you specify in the docker save command, so other tags will be re-pulled on every build if a tag is not specified in the FROM command." [1] https://circleci.com/docs/docker/#caching-docker-layers --- android-arm/Dockerfile | 2 +- linux-arm64/Dockerfile | 2 +- linux-armv5/Dockerfile | 2 +- linux-armv6/Dockerfile | 2 +- linux-armv7/Dockerfile | 2 +- linux-ppc64le/Dockerfile | 2 +- linux-x64/Dockerfile | 2 +- linux-x86/Dockerfile | 2 +- windows-x64/Dockerfile | 2 +- windows-x86/Dockerfile | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-) diff --git a/android-arm/Dockerfile b/android-arm/Dockerfile index d4e9e29..8c7791a 100644 --- a/android-arm/Dockerfile +++ b/android-arm/Dockerfile @@ -1,4 +1,4 @@ -FROM dockcross/base +FROM dockcross/base:latest MAINTAINER Matt McCormick "matt.mccormick@kitware.com" # The cross-compiling emulator diff --git a/linux-arm64/Dockerfile b/linux-arm64/Dockerfile index a220d27..78d2830 100644 --- a/linux-arm64/Dockerfile +++ b/linux-arm64/Dockerfile @@ -1,4 +1,4 @@ -FROM dockcross/base +FROM dockcross/base:latest MAINTAINER Matt McCormick "matt.mccormick@kitware.com" # Add the cross compiler sources diff --git a/linux-armv5/Dockerfile b/linux-armv5/Dockerfile index 80ecb96..27f67aa 100644 --- a/linux-armv5/Dockerfile +++ b/linux-armv5/Dockerfile @@ -1,4 +1,4 @@ -FROM dockcross/base +FROM dockcross/base:latest MAINTAINER Matt McCormick "matt.mccormick@kitware.com" # This is for ARMv5 "legacy" (armel) devices which do NOT support hard float diff --git a/linux-armv6/Dockerfile b/linux-armv6/Dockerfile index 01adce8..a7e1d8f 100644 --- a/linux-armv6/Dockerfile +++ b/linux-armv6/Dockerfile @@ -1,4 +1,4 @@ -FROM dockcross/base +FROM dockcross/base:latest MAINTAINER Matt McCormick "matt.mccormick@kitware.com" # Enable 32 bits binaries diff --git a/linux-armv7/Dockerfile b/linux-armv7/Dockerfile index 6cf6485..087b2a4 100644 --- a/linux-armv7/Dockerfile +++ b/linux-armv7/Dockerfile @@ -1,4 +1,4 @@ -FROM dockcross/base +FROM dockcross/base:latest MAINTAINER Matt McCormick "matt.mccormick@kitware.com" # Add the cross compiler sources diff --git a/linux-ppc64le/Dockerfile b/linux-ppc64le/Dockerfile index 1903ef8..73008c0 100644 --- a/linux-ppc64le/Dockerfile +++ b/linux-ppc64le/Dockerfile @@ -1,4 +1,4 @@ -FROM dockcross/base +FROM dockcross/base:latest MAINTAINER Matt McCormick "matt.mccormick@kitware.com" # Add the cross compiler sources diff --git a/linux-x64/Dockerfile b/linux-x64/Dockerfile index c92c737..5f7da03 100644 --- a/linux-x64/Dockerfile +++ b/linux-x64/Dockerfile @@ -1,4 +1,4 @@ -FROM dockcross/base +FROM dockcross/base:latest MAINTAINER Matt McCormick "matt.mccormick@kitware.com" ENV CROSS_TRIPLE x86_64-linux-gnu diff --git a/linux-x86/Dockerfile b/linux-x86/Dockerfile index 62fa062..6ea2e11 100644 --- a/linux-x86/Dockerfile +++ b/linux-x86/Dockerfile @@ -1,4 +1,4 @@ -FROM dockcross/base +FROM dockcross/base:latest MAINTAINER Matt McCormick "matt.mccormick@kitware.com" RUN dpkg --add-architecture i386 && \ diff --git a/windows-x64/Dockerfile b/windows-x64/Dockerfile index 54de25c..61d06db 100644 --- a/windows-x64/Dockerfile +++ b/windows-x64/Dockerfile @@ -1,4 +1,4 @@ -FROM dockcross/base +FROM dockcross/base:latest MAINTAINER Matt McCormick "matt.mccormick@kitware.com" # WINE is used as an emulator for try_run and tests with CMake. diff --git a/windows-x86/Dockerfile b/windows-x86/Dockerfile index 2bc0d4a..e8fcf76 100644 --- a/windows-x86/Dockerfile +++ b/windows-x86/Dockerfile @@ -1,4 +1,4 @@ -FROM dockcross/base +FROM dockcross/base:latest MAINTAINER Matt McCormick "matt.mccormick@kitware.com" # WINE is used as an emulator for try_run and tests with CMake.