Bensuperpc/dockcross
1
0
Fork 0
mirror of https://github.com/bensuperpc/dockcross.git synced 2024-12-22 16:24:27 +01:00
Code Issues Packages Projects Releases Wiki Activity

Makefile: Make sure base.test also create bin directory

Browse Source 
This commit fixes a regression [1] introduced in 606d0b3 (Makefile: Make sure
BIN directory exist when running any test)

Reported below the dry-run summary before and after, we can confirm the
bin directory is now created when building the `base.test` target.

Before:

$ make base.test --dry-run
docker build -t dockcross/base .
docker run --rm dockcross/base > bin/dockcross-base && chmod +x bin/dockcross-base

After:

$ make base.test --dry-run
docker build -t dockcross/base .
mkdir -p bin
docker run --rm dockcross/base > bin/dockcross-base && chmod +x bin/dockcross-base


[1] Error fixed by this commit:

Successfully built e6388fe49824
docker run --rm dockcross/base > bin/dockcross-base && chmod +x bin/dockcross-base
/bin/sh: 1: cannot create bin/dockcross-base: Directory nonexistent
make: *** [base.test] Error 2

make base.test returned exit code 2
This commit is contained in:
Jean-Christophe Fillion-Robin 2016-09-26 11:38:43 -04:00
parent cf3cec8819
commit 97385c1356
No known key found for this signature in database
GPG Key ID: 15C1A2812F958BD3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Makefile
View File

@ -114,6 +114,6 @@ $(addsuffix .test,$(STANDARD_IMAGES)): $$(basename $$@)
test.prerequisites: test.prerequisites:
mkdir -p $(BIN) mkdir -p $(BIN)
$(addsuffix .test,$(IMAGES)): test.prerequisites $(addsuffix .test,base $(IMAGES)): test.prerequisites
.PHONY: base images $(IMAGES) test %.test .PHONY: base images $(IMAGES) test %.test